Improved localization. #1807
Merged
Improved localization. #1807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested. Works fine after |
|
It didn't find the messages because they weren't constants, but stored in variables. Now, I modified the library to use the |
|
Please squash so I can have a better look. |
|
Dan, in the SQL query form. The hint on the red X says So parameter subtitution does not happen. |
Updated sql-parser library to phpmyadmin/sql-parser@e1b91ed. Signed-off-by: Dan Ungureanu <udan1107@gmail.com>
|
Nice job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved localization.
Updated the sql-parser library to phpmyadmin/sql-parser@e5fc868.
I didn't get to test it. I will tomorrow.
I had to refactor the code a little bit to be able to use user's preferences (language selection).
Signed-off-by: Dan Ungureanu udan1107@gmail.com